Geert-Johan Riemer

Results 151 comments of Geert-Johan Riemer

Can you elaborate a bit on this request? A box is supposed to be a set of resources that are required by the program, I think the box folder should...

I'm thinking about changing how rice embeds/appends boxes to a binary. Please read and comment on #47 This request sounds like a good idea for it.

I was able to make some simple changes to the parser so that it accepts type literals in struct field definitions. This now has a lower priority.

What version of Go are you using?

I think Go 1.11 is quite old. I'm not 100% sure if it's the source of the issue you're having, but could you please try updating Go first? `pe.IMAGE_FILE_MACHINE_ARMNT` is...

Whoops, I said kill where I meant interrupt. Edited issue.

One could argue to use SIGTERM, instead of `os.Interrupt` (SIGINT). However, SIGTERM is not abstracted by Go's `os` package. I think it isn't cross-platform supported.... afaik: os.Interrupt is.

What are your thoughts on SIGINT vs SIGTERM? @skelterjohn

I have removed formatting changes from this PR, and opened a separate PR for it; #124

Tests failed... > remote: Cannot obtain refs from GitHub: cannot talk to GitHub: Get https://github.com/intercom/intercom-go.git/info/refs?service=git-upload-pack: dial tcp 140.82.114.4:443: socket: too many open files Looks like the CI/CD runner is too...