NativeBase icon indicating copy to clipboard operation
NativeBase copied to clipboard

Box, Skeleton, and other components do not contain type definitions for "variant" prop

Open vasafix opened this issue 3 years ago • 1 comments

Description

Box, Skeleton, and other components do not contain type definitions for the "variant" prop, even though if the "variant" prop is defined in "extendTheme" it is still applied.

CodeSandbox/Snack link

https://snack.expo.dev/@krygelv/native-base-variant

Steps to reproduce

run tsc

NativeBase Version

3.4.11

Platform

  • [ ] Android
  • [ ] CRA
  • [ ] Expo
  • [ ] iOS
  • [ ] Next

Other Platform

No response

Additional Information

No response

vasafix avatar Aug 08 '22 14:08 vasafix

Hey @vasafix, Thanks for reporting the issue. We'll look into it.

ankit-tailor avatar Aug 09 '22 06:08 ankit-tailor

Hey guys! Any progress on this? 😄

hirvesh avatar Aug 29 '22 15:08 hirvesh

Yes, We are working on it. It will be fixed in the next release.

ankit-tailor avatar Aug 30 '22 12:08 ankit-tailor

Hi Everyone, This issue is fixed in 3.4.14.

ankit-tailor avatar Sep 09 '22 08:09 ankit-tailor

Thanks!

ftzi avatar Sep 09 '22 10:09 ftzi