web icon indicating copy to clipboard operation
web copied to clipboard

Performance Budget Check

Open jamesgeddes opened this issue 4 years ago • 4 comments

Add check to ensure that proposed deployment does not breach our performance budget

budget = kb

Impact

High

Urgency

Later

jamesgeddes avatar Feb 02 '21 17:02 jamesgeddes

Made some progress on this today. Looks like Lighthouse might be a good direction to go, but it does rely on package.json so may require some yak shaving.

jamesgeddes avatar Feb 08 '21 21:02 jamesgeddes

We do now have a package.json since we brought in tailwindcss, but I'm not sure how accurate lighthouse will be in this scenario?

CarwynNelson avatar Feb 08 '21 21:02 CarwynNelson

ah I didn't know about that. this branch also has a package.json so I will remove it.

Re accuracy, I was under the impression that the intention of lighthouse is to test performance, is that not correct?

Moving to P2 as this is not absolutely necessary to get the MVP working.

jamesgeddes avatar Feb 09 '21 06:02 jamesgeddes

Re accuracy, I was under the impression that the intention of lighthouse is to test performance, is that not correct?

I can't quite remember why I wrote this comment, so I guess this is a lesson for me to just add the whole context to a comment and not assume I'll be able to explain it later. :facepalm:

CarwynNelson avatar Feb 21 '21 09:02 CarwynNelson