Gabriel Marquet
Gabriel Marquet
Seems like https://github.com/g-wilson/action-semgrep already exists
Just found myself wishing I had this simple cli exclude flag ! Thanks for filing :) I think we're going to see a lot of "forking" of base rulesets (the...
You can do that already with a comment on the line I think
I have added a regex parsing for endpoints because I kept getting errors I have mentioned in https://github.com/DefectDojo/django-DefectDojo/issues/6580 ! Submissions can have random stuff in their bug_url, not just urls...
@Maffooch all good :) I copied tests from Edgescan
Done ! The bugcrowd api uses an annoying query format for JSONAPI, with brackets everywhere, this definitely looks better now
Implemented a generator pattern for the api client function, no gain in performance since it stays sequential, removes the "accumulator" logic from the function that's all A better pattern would...
Code is functional, could be improved a bit with URI parsing and handling more use cases (bug urls in Bugcrowd are not always URL/URIs, sometimes just hosts, sometimes just paths...
@damiencarol @Maffooch @kiblik if I can get a last review, it should be all good 🤔
Not sure why one test failed, is that normal ?