GavinJoyce
Add menu with popper example
This is a breaking change, so if ya'll don't want to go along with this, that's fine by me.
the breaking change is that any consuming project must also be using ember-auto-import@v2
The demo is the same as the "Basic" Menu demo, and is only has noticeable differences on super small screens where popper starts to take control of positioning as layout constraints come in to play
the breaking change is that any consuming project must also be using ember-auto-import@v2
I think it's fine for us to make breaking changes like this 👍
FYI, it looks like there are some failing tests in CI
excellent! because ember-auto-import@v2 is a requirement for ember 4 :D
I'm not sure how any of these were passing 🤔
I assume most of this was copied from either the React or Vue repo?
It seems back when we were on webpack 4 (ember-auto-import@v1, a bunch of implicit non-browser behaviors were getting polyfilled)
I'm totally fine with making a breaking change and upgrading to ember-auto-import@2, but could that work be split out into a separate PR? I think that would make it easier to review the code and understand the affect.
In this PR at least, it seems that ember-auto-import is only a development dependency, so I'm not sure that would be a breaking change?
FYI, I've updated ember-auto-import here: https://github.com/GavinJoyce/ember-headlessui/pull/111