resize-observer-hook icon indicating copy to clipboard operation
resize-observer-hook copied to clipboard

Published 20 hours ago • verified publisher icon Gautam-Arora24

migration: Migrate to Typescript.

Open nikhilmaske-2001 opened this issue 3 years ago • 4 comments

Fixes #20. Renamed all files with extension .tsx.

Testing plan: Everything works fine after this changes.

nikhilmaske-2001 avatar Sep 28 '21 07:09 nikhilmaske-2001

Hook should end in .ts since they are not returning any jsx. Also, types are needed first, not just changing the file extension.

boxdox avatar Sep 28 '21 08:09 boxdox

@boxdox Almost all functions are returning the jsx element, can you please check it again? Yes, I am working on adding types.

nikhilmaske-2001 avatar Sep 28 '21 08:09 nikhilmaske-2001

i am talking about src/index.js, that's a plain hook, no jsx returned. also, i am curious what does this project offer, when there are alternatives available?

boxdox avatar Sep 28 '21 09:09 boxdox

@boxdox Currently the library is bare-bone, and I have few ideas that can be implemented in the library -->

  • Measure dimensions of lazy-loaded elements.
  • Add testing support to the library.

If you have any ideas that can make this library stand out from others, feel free to post them in this issue. Thanks 🙂

Gautam-Arora24 avatar Sep 28 '21 11:09 Gautam-Arora24