ProKeys icon indicating copy to clipboard operation
ProKeys copied to clipboard

Modularizing the options html page

Open GaurangTandon opened this issue 5 years ago • 5 comments

The current options page is a complete mess. Addition/removal of any new configurable option requires going through different parts of the script(s) and manually changing them.

I would imagine an extensible system ("factory" maybe?) that generalizes a setting element, given the following:

  1. The UI for a setting, based on whether it is input, textarea, checkbox, etc. The factory should also have defaults.
  2. Have a default handler that updates the value in Data, as well as pre-functions for validation of user input and post-functions as callbacks after Data is updated.
  3. other minute details can be added I believe.

GaurangTandon avatar Jun 04 '19 10:06 GaurangTandon

Hi. I see that this issue has been self-assigned, but I would be happy to help with the UI-Design part if its open for me.

ShivanshRakesh avatar Aug 12 '19 17:08 ShivanshRakesh

A sample UI-Design modification I propose is to change this:

Screenshot from 2019-08-13 02-01-17

To this:

Screenshot from 2019-08-13 02-00-35

ShivanshRakesh avatar Aug 12 '19 20:08 ShivanshRakesh

Thanks dude. But this is already being worked on by @JAIDEV123 and there's a big redesign coming up :)

GaurangTandon avatar Aug 13 '19 02:08 GaurangTandon

Do checkout Prokeys-Frontend on my github and suggest anything you feel should be there!

jaidevshriram avatar Aug 13 '19 02:08 jaidevshriram

Oh okay! I thought no one else was on it since it was self assigned. Nvm. Sure @JAIDEV123 :)

ShivanshRakesh avatar Aug 13 '19 05:08 ShivanshRakesh