gatorgrader icon indicating copy to clipboard operation
gatorgrader copied to clipboard

Check commit messages for specific fragments and/or length

Open gkapfham opened this issue 7 years ago • 5 comments

The current implementation of GatorGrader can only count the number of commits in a repository past a certain number. However, it would also be useful if the tool could look for fragments inside of a commit message. For instance, one idea would be that students must add a numerical rating for their level of frustration associated with that commit. Alternatively, GatorGrader could check to see if the commit messages contain an emoji in them (perhaps from a set list of emoji). Finally, it might be a good idea to introduce checks that can ensure that commit messages have a minimum or a maximum number of characters in them. Of course, if we introduce this type of feature, then we would also have to explain to students how to revise their commit messages so that they meet the standard that we are asking them to follow.

gkapfham avatar Sep 13 '18 13:09 gkapfham

Currently working on this issue to check if commit messages meet a length requirement.

baldeosinghm avatar Feb 26 '19 23:02 baldeosinghm

Hello @baldeosinghm can you please update as to whether or not you finished working on a PR that resolves this issue? Your note is the last one in the issue tracker and thus I wanted to check with you today! Thanks for any updates that you can share!

gkapfham avatar Apr 17 '19 11:04 gkapfham

I wanted to write that I plan to implement this feature in the next few days. @quigley-c and @baldeosinghm if you would like to review the PR for this work, please let me know. Thanks!

gkapfham avatar Jun 14 '19 01:06 gkapfham

I plan to work on this issue after implementing the new "linting-style" interface to GatorGrader.

gkapfham avatar Jun 17 '19 16:06 gkapfham

@Michionlion I have put this issue on hold until after we implement the linting interface. My view is that, currently, adding this feature would require me to change the command-line interface, which I would prefer not to do and then have to change once we implement the linting approach.

gkapfham avatar Jun 20 '19 03:06 gkapfham