Removed rootbeer lib as it's causing false positives

[adamivancza]

This part of the library is causing some false positives. We've spotted this issue on a Samsung Galaxy S20+. https://github.com/scottyab/rootbeer#false-positives

I tried to replace rootBeer.isRootedWithBusyBoxCheck(); with rootBeer.isRooted(); but that also has the same false positive on a Samsung Galaxy S20+. So I decided to remove that library entirely to get rid of this false positive.

Not entirely sure if that's the right approach or shall we do some further checks now? I'm totally open for discussions here :)

[levibuzolic]

Thanks for the contribution @adamivancza, do you have any idea what specific check may be triggering the false positive? The RootBeer sample app might help narrow down the problem area.

Also any chance you tried with the latest version of rootbeer? Though it doesn't look like there's any changes in 0.1.0 that would improve the behaviour.

I'm wondering if maybe it's worth adding an option like isJailBroken({rootbeer: true}) and disabling rootbeer by default, but allowing users to opt into the additional checks.

[adamivancza]

hey @levibuzolic!

yeah I did tried it with the RootBeer sample app and it failed the following 2 checks:

• SE linux Flag is Enabled
• For RW Paths

I also tried to update to 0.1.0 but that has the same issue.

I do like that optional idea though! Maybe we can even mention the false positive risk by enabling it in the README?

[Vincenttbk]

Hi, was wondering if there is issue for merging the PR into the main branch? :)

[levibuzolic]

@Vincenttbk merging this in it's current state would mean that the root checking on Android becomes so minimal that this library stops providing any significant value.

Instead I'd be happy to merge a PR that makes the check optional via configuration or replaces RootBeer with an alternative root detection library.

[Vincenttbk]

Alright! Noted and thank you very much for the explanation :D