GM4_Datapacks icon indicating copy to clipboard operation
GM4_Datapacks copied to clipboard

Zauber Cauldrons: Zauber Armor generic.armor does not stack properly with other custom armor attributes

Open EpyonProjects opened this issue 1 year ago • 1 comments

Describe the bug Zauber Cauldrons copies existing armor attributes then adds its own custom copy of attributes, adding its own modified minecraft:generic.armor , potentially causing a much higher armor value than expected

To Reproduce Steps to reproduce the behavior:

  1. Obtain armor that recreates the vanilla armor attributes (like Combat Expanded armor)
  2. Convert into Zauber Armor with the armor bonus
  3. Get Zauber Armor with duplicated vanilla armor amount

Expected behavior Zauber should not add vanilla armor amount more than once

Fix

  1. Vanilla attributes have default UUID values for every attribute. When recreating the vanilla values, you should use this (without modifying)
  2. Zauber should add its own custom attribute rather than modifying the vanilla value (I know it adds another lore line, deal with it :P)

Screenshots image

Environment

  • Minecraft version: 1.20.4
  • Server version: Public Server 10
  • Installed Datapacks: All, but most importantly Combat Expanded and Zauber Cauldrons
  • Installed Mods: None

Additional context Have fun updating CE And ZC :) Each equipment slot has a separate vanilla UUID. Attributes apply onto the player, so you can't have duplicates. Good luck

EpyonProjects avatar Feb 28 '24 18:02 EpyonProjects

For clarification, CE will also need adjsuting; the core issue here is that both CE and ZC have been dealing with vanilla attributes slightly wrongly, generating a vanilla attribute with a random UUID where the UUID should be fixed per attribute-slot combination.

Bloo-dev avatar Feb 29 '24 10:02 Bloo-dev