LinuxGSM icon indicating copy to clipboard operation
LinuxGSM copied to clipboard

feat(newserver): add FabricMC Server

Open Ceddicedced opened this issue 3 years ago • 6 comments

Description

Fabric is a modular modding toolchain targeting Minecraft 1.14 and above, including snapshots.

I took #3292 as an example.

Type of change

  • [ ] Bug fix (a change which fixes an issue).
  • [ ] New feature (change which adds functionality).
  • [X] New Server (new server added).
  • [ ] Refactor (restructures existing code).
  • [ ] Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • [ ] This pull request links to an issue.
  • [X] This pull request uses the develop branch as its base.
  • [ ] This pull request Subject follows the Conventional Commits standard.
  • [X] This code follows the style guidelines of this project.
  • [X] I have performed a self-review of my code.
  • [X] I have checked that this code is commented where required.
  • [X] I have provided a detailed with enough description of this PR.
  • [X] I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

  • User docs: https://github.com/GameServerManagers/LinuxGSM-Docs
  • Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs

Thank you for your Pull Request!

Ceddicedced avatar Jun 07 '21 17:06 Ceddicedced

Would it be possible for you to rebase this branch on the latest release ?

h3o66 avatar Dec 10 '21 10:12 h3o66

I will look into this. Thanks for your feedback

Ceddicedced avatar Dec 14 '21 13:12 Ceddicedced

I've now checked all your comments and updated my changes to the latest version of the develop branch

looks better, but only 2 litte changes are needed

h3o66 avatar Dec 15 '21 19:12 h3o66

Is there any update on this and is this going to be merged soon?

Jerry1098 avatar Jul 30 '22 18:07 Jerry1098

Hi, I'm interested in this merge soon. Is it stalled ?

meguroyama avatar Dec 08 '22 16:12 meguroyama

Hi, I'm interested in this merge soon. Is it stalled ?

I'm interested as well.

whytf avatar Apr 02 '24 22:04 whytf