LinuxGSM icon indicating copy to clipboard operation
LinuxGSM copied to clipboard

feat(command) adds a command to place the systemd service file in the right location

Open legendofmiracles opened this issue 3 years ago • 7 comments

This PR adds a command to generate a systemd service file and places it in the /etc/systemd/system, so that the user can easily enable a gameserver upon boot, without having to write his/her own service file.

Why only systemd?

Because all the official supported distros use systemd and most distros in general as well. If people request other init systems, i'd glady add support for those aswell.

  • [x] New feature (change which adds functionality).

Checklist

  • [x] This pull request uses the develop branch as its base.
  • [x] This pull request Subject follows the Conventional Commits standard.
  • [x] This code follows the style guidelines of this project.
  • [x] I have performed a self-review of my code.
  • [x] I have checked that this code is commented where required.
  • [x] I have provided a detailed with enough description of this PR.
  • [x] I have checked If documentation needs updating.

Documentation

EDIT: I opened a Pull request: https://github.com/GameServerManagers/LinuxGSM-Docs/pull/54

Showcase

(the last information text, prints "the game" instead of this) image

legendofmiracles avatar Dec 11 '20 07:12 legendofmiracles

Maybe you could squash/rebase the commits to one and do a commit title that matches the "Semantic Pull Request" standard. More info can be find in the dev docs: https://dev-docs.linuxgsm.com/getting-started/branching#pull-requests

h3o66 avatar Dec 22 '20 17:12 h3o66

Is this better?

legendofmiracles avatar Dec 22 '20 21:12 legendofmiracles

Is this better?

looks good to me

h3o66 avatar Dec 22 '20 21:12 h3o66

I added documentation: https://github.com/GameServerManagers/LinuxGSM-Docs/pull/54

legendofmiracles avatar Jan 01 '21 06:01 legendofmiracles

Also this will need to link to an issue and docs will need to be updated.

dgibbs64 avatar Jan 09 '21 21:01 dgibbs64

@dgibbs64 this PR links to an issue: image and i have also provided a update for the docs: https://github.com/GameServerManagers/LinuxGSM-Docs#54 (probably also riddled with spelling mistakes - english is not my native language)

legendofmiracles avatar Jan 12 '21 06:01 legendofmiracles

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Apr 20 '22 00:04 github-actions[bot]