SourceBans icon indicating copy to clipboard operation
SourceBans copied to clipboard

Show "Settings" link only for enabled plugins

Open ppalex7 opened this issue 11 years ago • 3 comments

I think it will be good to hide settings link for disabled plugins, because some plugins "runSettings" action can't work properly without overrides (from this plugin) for onBeginRequest

ppalex7 avatar Mar 01 '14 13:03 ppalex7

You need to be able to change settings even if the plugin is disabled. It should be a simple page for basic settings. What kind of overrides do you need in onBeginRequest for the settings page?

ErikMinekus avatar Mar 03 '14 07:03 ErikMinekus

At onBeginRequest I importing custom models, checking and adding to database nonexistence settings. Of course I could duplicate this code to the runSettings function, but i think it will looks strange.

ppalex7 avatar Mar 03 '14 08:03 ppalex7

Changing the settings of disabled plugin - seems strange to me.

ppalex7 avatar Mar 03 '14 21:03 ppalex7