vx_bevy icon indicating copy to clipboard operation
vx_bevy copied to clipboard

Simdnoise doesn't support non-x86

Open merlinfuchs opened this issue 2 years ago • 4 comments

For anyone trying to get the world generation to work on a non-x86-target, you need to patch the 3.1.6 version of simdnoise with this commit https://github.com/jackmott/rust-simd-noise/commit/23c690578a2ce2bc5f9d6eb7faf730ea909baa47 .

I made a fork of simdnoise which does the trick for me:

simdnoise = { git = "https://github.com/merlinfuchs/rust-simd-noise", branch = "3.1.6-patch" }

Feel free to close this, just leaving this here if anyone runs into the same problem.

merlinfuchs avatar Mar 04 '22 11:03 merlinfuchs

Btw. the master of https://github.com/jackmott/rust-simd-noise doesn't work because the noise functions seem to produce different results.

merlinfuchs avatar Mar 04 '22 11:03 merlinfuchs

~~I thought simd stuff in the crate was platform-gated and that it would simply fallback to scalar on non-x86, that's unfortunate. I think opening a PR upstream for fixing this would be nice. In the mean-time maintaining a fork sounds good.~~ read a bit fast. What do you mean by master doesn't work ? Otherwise i guess we could just switch to use master while waiting for a crates.io release

Game4all avatar Mar 04 '22 15:03 Game4all

I haven't looked into what has changed exactly on master, but the results are very different. You will see what I mean when you run vx_bevy with the master branch of simdnoise.

merlinfuchs avatar Mar 04 '22 20:03 merlinfuchs

Checked out rust-simd-noise master branch, problem is due to the value scale of noise that changed, scaling it back to [-1.0, 1.0] should fix things. image

Game4all avatar Mar 05 '22 01:03 Game4all

#22

Game4all avatar May 01 '23 13:05 Game4all