blink icon indicating copy to clipboard operation
blink copied to clipboard

chore: re-organize tilt file

Open vindard opened this issue 1 year ago • 1 comments

Description

This is a preparatory step before I do some refactoring to separate out a build step from our Tiltfile

Note for BUILD_ARGS prepare_build_context is called inside npm_test_impl and is not its own rule. It doesn't get build if you call build on the npm_test_impl targets so this step still gets built in the test stage. To get around this, prepare_build_context would have to be broken out into its own rule and passed around accordingly.

vindard avatar Feb 09 '24 16:02 vindard

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7652397 Triggered Generic High Entropy Secret 69a03bc5f5a10d62b4b988cd59a9c28f3b15b542 dev/Tiltfile View secret
7652397 Triggered Generic High Entropy Secret 69a03bc5f5a10d62b4b988cd59a9c28f3b15b542 dev/Tiltfile View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Feb 09 '24 16:02 gitguardian[bot]

Taken over by other PRs

vindard avatar May 03 '24 16:05 vindard