blink icon indicating copy to clipboard operation
blink copied to clipboard

a lot of onchain_payment have pending: true despite being confirmed

Open nicolasburtey opened this issue 3 years ago • 3 comments

db.getCollection('medici_transactions').find({"type": "onchain_payment", "pending": true}).count() --> 356 db.getCollection('medici_transactions').find({"type": "onchain_payment"}).count() --> 914

looking at the log, it seems this is because the trigger Pod didn't receive the notification from lnd.

similar to the cleanup function for Lightning when a payment has been sent (updateUsersPendingPayment), another cron job should run daily to make sure sent on-chain transaction with 6 blocks confirmation are marked pending = false.

nicolasburtey avatar Feb 12 '21 22:02 nicolasburtey

is still happening?

dolcalmi avatar Jul 19 '21 16:07 dolcalmi

I believe so yes. this is related to the fact we don't seem to always receive events from lnd when a transaction is being confirmed.

but I think the move to bitcoind would solve this issue: https://github.com/GaloyMoney/galoy/pull/317 @jotapea

nicolasburtey avatar Jul 19 '21 16:07 nicolasburtey

Yes these events will be emitted by enabling ZeroMQ in bitcoind. https://github.com/GaloyMoney/galoy/issues/346 + https://github.com/GaloyMoney/galoy/pull/317 should solve this issue.

jotapea avatar Jul 19 '21 18:07 jotapea