blink-mobile icon indicating copy to clipboard operation
blink-mobile copied to clipboard

feat: plist localizations

Open MaxwellDG opened this issue 1 year ago • 1 comments

Addresses #611

This is a draft, but if its approved that we want to do this, Ill write a script to make the addition of new languages automated. At the moment I've only written 1 line in the il8n README, but Ill expand that to include the aforementioned script.

Also take note that I made 2 small changes to info.plist. We had a duplicate in there, and I removed a variable. Doesn't look like xCode localization .string files permit system variables like that.

MaxwellDG avatar Feb 01 '24 20:02 MaxwellDG

I think this PR is great and very well needed

ideally we would want to add those files somehow into transifex which is where people who are helping doing translation are going, and having everything centralized to transifex makes it much easier.

https://app.transifex.com/galoy/bitcoin-beach-wallet/

but now the challenge for integrating transifex is the upload/download from transifix and format management. I'm not sure if transifex would be working well with the InfoPlist.strings format. maybe worth researching.

I could see how this could be done manually because it's only a few strings, but if we add a string into this list, or add a new language, then it become a higher burden to maintain.

nicolasburtey avatar Feb 07 '24 00:02 nicolasburtey