blink-mobile icon indicating copy to clipboard operation
blink-mobile copied to clipboard

feat: Map Marker nav directly to Send Bitcoin Details

Open MaxwellDG opened this issue 1 year ago • 3 comments

Issue Send Bitcoin Destination screen doesn't serve a purpose when being pressed on a Map Marker.

Solution Navigate directly from a Map Marker to the Send Bitcoin Details screen

MaxwellDG avatar Jan 15 '24 17:01 MaxwellDG

  1. @designsats Think it's okay to omit the 'Alert. You're sending to a new contact' modal here? It's clicking on a business instead of manually typing one in like on the 'Send Bitcoin Destination'.

  2. @nicolasburtey Are all map marker addresses 100% confirmed to be accurate and functional? Or should I continue to include the parsing and validating step here to double-check.

MaxwellDG avatar Jan 30 '24 00:01 MaxwellDG

Or should I continue to include the parsing and validating step here to double-check. you mean on the mobile side? I think this info should be validated, but more on the backend/admin side. ie: we need a way to prevent "DDOS" attack of someone creating a lot of point that are irrelevant. right now the best way to think about that is a manual approval step in somewhere in the backend

that said, I think an additional value item to add, that was also added with Bitcoin Jungle, is a "report" button, so that if you go to a business and it's not accepting bitcoin, we could then either 1/ reach out to this business and offer a help if they have question or 2/ if they don't respond, or have no interest in accepting bitcoin any further it mean we should remove the business from the map. getting this input from our users would be valuable to make the map better

all that to say:

  • I don't think you should think of validating data from the mobile side
  • having a "report" button on the other end, be valuable

nicolasburtey avatar Jan 31 '24 00:01 nicolasburtey

@nicolasburtey I'll be a bit more specific here by what I meant by 'validating' on mobile side.

When a user reaches the 'Send Bitcoin Destination' screen, the input they write is validated when pressing 'next'.

https://github.com/GaloyMoney/galoy-mobile/assets/51105802/826fa3f4-8959-4877-9791-fbfc29e4c217

This 'validation' step is heavy enough to take .5 s - 2s. It's due to this function being called: https://github.com/GaloyMoney/galoy-mobile/blob/main/app/screens/send-bitcoin-screen/payment-destination/index.ts

I'm asking if we could skip this validating step when pressing on Map Markers. This would assert that we know with absolute certainty that all Map Marker addresses are accurate and functioning. Is that true currently?

MaxwellDG avatar Jan 31 '24 17:01 MaxwellDG