happo icon indicating copy to clipboard operation
happo copied to clipboard

requestAnimationFrame is not defined

Open coldpour opened this issue 8 years ago • 3 comments

Hey there,

I was wondering if you could help me figure out if this is a Happo issue or not. It looks like its coming from jsdom. Is this something that you might like to polyfill? You can see my build for more context.

https://travis-ci.org/mineral-ui/mineral-ui/jobs/338758728

Thanks, Mike

coldpour avatar Feb 08 '18 17:02 coldpour

Let me have a look.

trotzig avatar Feb 08 '18 18:02 trotzig

It might make sense to have a global polyfill for this. In the meantime, you can probably add your own polyfill using the setupScript config option: https://github.com/enduire/happo.io#setupscript

Oh, and this issue was filed in the wrong repo. New happo is in https://github.com/enduire/happo.io

trotzig avatar Feb 08 '18 20:02 trotzig

Perfect. Thanks for your help. And sorry for reporting in the wrong place!

On Thu, Feb 8, 2018 at 1:48 PM Henric Trotzig [email protected] wrote:

It might make sense to have a global polyfill for this. In the meantime, you can probably add your own polyfill using the setupScript config option: https://github.com/enduire/happo.io#setupscript

Oh, and this issue was filed in the wrong repo. New happo is in https://github.com/enduire/happo.io

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Galooshi/happo/issues/222#issuecomment-364243527, or mute the thread https://github.com/notifications/unsubscribe-auth/AKXd7JVvTvzmHaRXicZ-mngJsSNTKX5Lks5tS12YgaJpZM4R-uCc .

coldpour avatar Feb 08 '18 21:02 coldpour