pwntools
pwntools copied to clipboard
create a windows process
Pwntools Pull Request
Thanks for contributing to Pwntools! Take a moment to look at CONTRIBUTING.md
to make sure you're familiar with Pwntools development.
Please provide a high-level explanation of what this pull request is for.
Redo of this PR https://github.com/Gallopsled/pwntools/pull/1952 in a more incremental way. Tell me if this is not enough incremental. I will redo this again. But please do not close this issue.
Testing
Pull Requests that introduce new code should try to add doctests for that code. See TESTING.md
for more information.
Target Branch
Depending on what the PR is for, it needs to target a different branch.
You can always change the branch after you create the PR if it's against the wrong branch.
Branch | Type of PR |
---|---|
dev |
New features, and enhancements |
dev |
Documentation fixes and new tests |
stable |
Bug fixes that affect the current stable branch |
beta |
Bug fixes that affect the current beta branch, but not stable |
dev |
Bug fixes for code that has never been released |
Changelog
After creating your Pull Request, please add and push a commit that updates the changelog for the appropriate branch.
You can look at the existing changelog for examples of how to do this.
This is only a draft PR. I Plan to: -document the windows process -separate process() and PE() classes. -fix imports in setup.py instead of requirements.txt
Ready for a review!!!
I even implemented tests and set these on travis. I plan to write more tests on the future.
The only issue I could see is the pipes variables on the top. Still a very good PR.
I had to delete the method _recv. This is just a duplicate of recv. I think the code is cleaner now.
I still have to make my own code cleaner.
No worries, but if you could try to push a bit less frequently... (you can test off-line, see TESTING.md) Every push sends an email saying “gogo2464 pushed 1 commit” and it spans all over our mailboxes.
Email ze środy 20 października 2021 od gogo2464:
I had to delete the method _recv. This is just a duplicate of recv. I think the code is cleaner now.
I still have to make my own code cleaner.
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Gallopsled/pwntools/pull/1959#issuecomment-94771147
-- Wysłane z mojego urządzenia Sailfish
Don't know how this is different from #1978. Closing as it has longstanding conflicts and no progress whatsoever.