pwntools icon indicating copy to clipboard operation
pwntools copied to clipboard
verified publisher icon Gallopsled

Refactor encoders

Open Arusekk opened this issue 5 years ago • 2 comments

Most changes to ARM alphanumeric (reduced duplication and fixed indentation).

Arusekk avatar Jun 14 '20 14:06 Arusekk

I know you put a lot of effort into refactoring the ARM encoders, but I'm hesitant to do so without working tests (since the encoders have all been broken for some time). All of the code was lifted from an academic paper, so any diversion from that is a maintenance burden.

zachriggle avatar Jun 16 '20 03:06 zachriggle

Agree with @zachriggle it would be nice to get the encoders working and tested before refactoring / rewriting them.

heapcrash avatar Jun 16 '20 19:06 heapcrash