Michael Brevard comments

Results 148 comments of


                                            Michael Brevard

perf: deallocate out-of-scope references

Hey @danielroe ! I wanted to get your opinion on this because it is a trade-off: This PR would optimize memory utilization of the dev server and the prod build...

perf: deallocate out-of-scope references

Hey @danielroe ! I appreciate your response. First of all, I do not take it as lack of appreciation, I fully understand your point. TL;DR if you could assist with...

perf: deallocate out-of-scope references

I appreciate your response! I'll try to set up profiling similar to the one I made in #29620. That's the most reliable profiler I managed to find. I'll post the...

feat(storage): add type safety to useStorage

So there's a slight issue with the tests. Since `mountPoints` gets populated on-the-go, as the user mounts more storage points, it starts off as "" or undefined, causing the test...

feat(storage): add type safety to useStorage

I think this is at the limit of typescript, as the tests fail with values being generated at runtime, so it can't parse them correctly, but I'm gonna try a...

fix(server-renderer): Make sure dir is defined

Hey! Thanks for the feedback! > 1. The type of `dir`. If we're going to handle `undefined`, shouldn't `dir: Directive` be updated to reflect that? In this case, is there...

perf: deallocate out-of-scope references

This PR might take some time as I have to carefully review which patterns would benefit from it. Thanks to the linked PR, the memory footprint has been optimized, so...

perf: deallocate out-of-scope references

I will have to look into webpack-related patterns

perf: deallocate out-of-scope references

Continued in #32162

perf: deallocate out-of-scope references

Of course @danielroe ! I just got some time for a little bit ever since the personal life change I told you about a few months back, so I figured...