JAX-GalSim icon indicating copy to clipboard operation
JAX-GalSim copied to clipboard

spergel profiles are much slower than galsim

Open beckermr opened this issue 1 year ago • 5 comments

I've heard reports that the spergel profiles are much slower than galsim.

To Do:

  • [x] add benchmark comparison to galsim
  • [ ] profile to find optimizations
  • [x] implement those optimizations

beckermr avatar Dec 10 '24 19:12 beckermr

quick note, when I checked it was a sum of Exponential and Spergel profile (nu=-0.6) -- might be worth taking a look at the timing of each of these separately, but my guess is that it's very likely coming from the Spergel...

ismael-mendoza avatar Dec 11 '24 14:12 ismael-mendoza

We've determined that this is from the conversion of half light radius to scale radius. So we're going to focus our optimization on those bits of the code.

beckermr avatar Jan 07 '25 19:01 beckermr

is this still relevant after #130 ? i forgot about the status, perhaps we can close this issue

ismael-mendoza avatar Nov 06 '25 21:11 ismael-mendoza

There is still one other thing here I think.

beckermr avatar Nov 06 '25 21:11 beckermr

i see, do you agree if I check off the first and third item based on #125 and #130? so just the second one is missing (?)

ismael-mendoza avatar Nov 06 '25 22:11 ismael-mendoza