Gal Rogozinski

Results 90 comments of Gal Rogozinski

I just started a node from scratch (global snapshot) and didn't get an error. @JakeSCahill when you have time can you try to follow the guide and see if something...

@DyrellC let's update this test with #1772 and merge

I was considering using jax-rs. However, since your solution may also be satisfactory it may be accepted when we come around to refactor the API.

Hey @yovendielmundo, Will you be willing to do an implementation of the API using JAX-RS with RESTEASY? I liked your use of the commander pattern but I think that for...

That makes good sense actually. Go for it. I'll keep an eye on this PR. On Sun, May 13, 2018, 8:13 PM Bruno A. dos Santos wrote: > @GalRogozinski What...

You are just missing the `` topic. See [ZMQ README](https://github.com/iotaledger/iri/blob/dev/src/main/java/com/iota/iri/zmq/README.md) and https://github.com/iotaledger/iri/blob/d5252270594d11421bf53b912d913369a1438c2e/src/main/java/com/iota/iri/service/milestone/impl/MilestoneServiceImpl.java#L422

Please don't shout when using imports with wildcards that are more than 5 packages deep

Javadocs don't have to be on Benchmark class declaration. They can be on Benchmark methods though

Too hard to do a regression test for this, we need to make sure a unit test is in place

@karimodm maybe it is unlikely but could the `revalidate` issue you had could be related to this?