ISIC-Archive-Downloader icon indicating copy to clipboard operation
ISIC-Archive-Downloader copied to clipboard

Published 20 hours ago • verified publisher icon GalAvineri

Format invalid data

Open pkill37 opened this issue 5 years ago • 2 comments

It would be nice if this script came bundled with a utility to filter out invalid data like https://github.com/GalAvineri/MelMedic/blob/master/data/format_data.py#L16

The other utilities are nice too but too specific to your particular project (e.g. I might prefer a different validation scheme) whereas surely everyone wants to filter out invalid data.

pkill37 avatar Mar 01 '19 15:03 pkill37

If you want I can make a PR that adds a filter_invalid.py script to do this.

I would try to adhere to your coding style as much as possible and you can further improve it later.

pkill37 avatar Mar 01 '19 16:03 pkill37

I went ahead and did it. I suggest you merge it ASAP for anyone that needs it and, if you feel necessary, improve it later.

pkill37 avatar Mar 01 '19 18:03 pkill37