clean-fid icon indicating copy to clipboard operation
clean-fid copied to clipboard

Uppercase JPEG extension ignored by get_folder_features

Open Reason239 opened this issue 1 year ago • 2 comments

Hi! Uppercase JPEG extension ignored by get_folder_features I've noticed this issue while making custom statistics from a folder with .JPEG files. It seems like it has been thought of here for processing .zip https://github.com/GaParmar/clean-fid/blob/b1d8934d7ebb7e0c471f7bdb4c12872fe62f6cc4/cleanfid/fid.py#L138 but not here for processing folders https://github.com/GaParmar/clean-fid/blob/b1d8934d7ebb7e0c471f7bdb4c12872fe62f6cc4/cleanfid/fid.py#L140-L141

Probably the easiest fix is to expand the EXTENSIONS with the upper-case versions

Reason239 avatar Sep 01 '22 15:09 Reason239

Hi,

I have added the uppercase extensions in the latest version of the library (0.1.31). Let me know if the issue is not resolved yet.

-Gaurav

GaParmar avatar Sep 12 '22 16:09 GaParmar

Hi,

Linux's file system is case-sensitive and it will find *.jpg and *.JPG differently.

However, it will double count the number of files on Windows. The latest version will cause the issue.

Thanks!

yzy1996 avatar Nov 24 '22 06:11 yzy1996