gudhi-devel icon indicating copy to clipboard operation
gudhi-devel copied to clipboard

Published 20 hours ago • verified publisher icon GUDHI

c++17 as a new standard to compile the library

Open VincentRouvreau opened this issue 2 years ago • 2 comments

Update also the installation manual as Visual Studio 2017 is also required. Fix compilation error in tangential benchmark as std::ofstream::streampos seems deprecated with c++17.

VincentRouvreau avatar Sep 14 '22 08:09 VincentRouvreau

ok once we merge something that actually needs it.

As @hschreiber needs this feature for the persistence matrix PR #669 , I would like to merge it now. Is it ok for you ?

VincentRouvreau avatar Oct 05 '22 06:10 VincentRouvreau

As @hschreiber needs this feature for the persistence matrix PR #669 , I would like to merge it now. Is it ok for you ?

The cleaner way would be to have Hannah's branch merge this one and still only merge this one into master later, but let's not bother, ok to merge it now to master.

mglisse avatar Oct 13 '22 19:10 mglisse