gudhi-devel icon indicating copy to clipboard operation
gudhi-devel copied to clipboard

Obsolete doxygen settings

Open albert-github opened this issue 2 years ago • 3 comments

In the current master the settings

  • DOT_TRANSPARENT and FORMULA_TRANSPARENT are obsolete.
  • DOT_FONTNAME / DOT_FONTSIZE are incorporated into the new ...ATTR settings

albert-github avatar Aug 11 '22 12:08 albert-github

@albert-github What is the doxygen version from which this will become obsolete ? I am with doxygen 1.9.3 and I have the following warnings:

warning: ignoring unsupported tag 'DOT_COMMON_ATTR' at line 2178, file /home/gailuron/workspace/gudhi/gudhi-devel/build/version/build/Doxyfile
warning: ignoring unsupported tag 'DOT_EDGE_ATTR' at line 2187, file /home/gailuron/workspace/gudhi/gudhi-devel/build/version/build/Doxyfile
warning: ignoring unsupported tag 'DOT_NODE_ATTR' at line 2195, file /home/gailuron/workspace/gudhi/gudhi-devel/build/version/build/Doxyfile

VincentRouvreau avatar Aug 12 '22 07:08 VincentRouvreau

This is now only available in the current master (1.9.5 (0bddda57211df25c81b456d255688f251a939a37)) and will be in the forthcoming 1.9.5 when released. So indeed in the 1.9.3 version it will give problems, to support multiple versions of doxygen you will probably need a strategy analogous to the strategy used by CGAL in respect to doxygen.

albert-github avatar Aug 12 '22 07:08 albert-github

The problem was intriguing me a bit (also as I was looking at some other settings regarding @CMAKE_...@), but probably some setting is needed in src/cmake/modules/GUDHI_doxygen_target.cmake analogous as done for the GUDHI_DOXYGEN_CLASS_DIAGRAMS. Actually the settings can be left out as they are anyway the default settings.

Please advise which version has the preference:

  • leaving out the settings as they are default
  • using a trick like done for GUDHI_DOXYGEN_CLASS_DIAGRAMS

albert-github avatar Aug 13 '22 14:08 albert-github

I think we can say that the minimal version of doxygen is 1.9.5, now that it is available as a conda package, so we could also remove GUDHI_DOXYGEN_CLASS_DIAGRAMS mechanism once this PR is merged.

However, the rendering is not exactly the same with your PR and doxygen 1.9.5. cf. PR 673 with doxygen 1.9.3 and PR 673 with doxygen 1.9.5. I don't know much about css, but would you have any idea of why the foreground became black ?

VincentRouvreau avatar Sep 15 '22 12:09 VincentRouvreau

I see both in "white" / "light".

To support the light and dark mode a new setting has been introduced: HTML_COLORSTYLE and the default here is AUTO_LIGHT which means "Automatically set the mode according to the user preference, use light mode if no preference is set", so it looks like your preference is the dark mode. Best is to add the setting `HTML_COLORSTYLE=LIGHT" to the settings file.

albert-github avatar Sep 15 '22 12:09 albert-github