gudhi-devel icon indicating copy to clipboard operation
gudhi-devel copied to clipboard

Published 20 hours ago • verified publisher icon GUDHI

make install puts Miniball.README in include

Open mglisse opened this issue 4 years ago • 4 comments

In make install, we copy Miniball.README and Miniball.COPYRIGHT to the include directory, which we probably shouldn't do.

mglisse avatar Nov 03 '20 00:11 mglisse

I placed Miniball.README and Miniball.COPYRIGHT in src/Cech_complex/include/gudhi and all the include/gudhi are copied and installed. I think it is important to install the COPYRIGHT file (the README is not that important...) or do you think https://gudhi.inria.fr/licensing/ is clear enough ?

VincentRouvreau avatar Nov 03 '20 16:11 VincentRouvreau

We don't install any license for the rest of gudhi. If we want to install it, include/ might not be the best place (?). The beginning of the file does mention its license. We should indeed clarify that miniball is shipped with gudhi: that makes it different from the other dependencies where if you don't install a GPL dependency, you are "safe".

mglisse avatar Nov 03 '20 17:11 mglisse

km.py.COPYRIGHT also gets installed, and this one seems less useful since the license is MIT.

mglisse avatar Nov 03 '20 18:11 mglisse

FWIW, we manually delete these files from include/gudhi in the Debian package.

gspr avatar Dec 28 '20 17:12 gspr

miniball was removed in #519.

mglisse avatar Mar 09 '23 21:03 mglisse