gudhi-devel icon indicating copy to clipboard operation
gudhi-devel copied to clipboard

[Alpha_complex_3d] CGAL new periodic features

Open mglisse opened this issue 4 years ago • 2 comments

CGAL is in the process of extending its periodic triangulations: https://github.com/CGAL/cgal/pull/4914

  • we may need/want to update the C++ Alpha_complex_3d after that
  • it would be nice to provide periodic 2d alpha-complexes
  • this may affect how we present the future python interface exactly.

mglisse avatar Aug 09 '20 15:08 mglisse

Note that the existing periodic triangulations are compatible with CGAL's alpha shapes, see https://doc.cgal.org/latest/Alpha_shapes_2/Alpha_shapes_2_2ex_periodic_alpha_shapes_2_8cpp-example.html / https://doc.cgal.org/latest/Alpha_shapes_3/Alpha_shapes_3_2ex_periodic_alpha_shapes_3_8cpp-example.html.

Do you have any specific requests on the periodic packages while I am working on them? (No promises I can do it, though :).)

MaelRL avatar Aug 25 '20 07:08 MaelRL

Hi @MaelRL,

Note that the existing periodic triangulations are compatible with CGAL's alpha shapes,

Yes, we are already using that in gudhi in this wrapper http://gudhi.gforge.inria.fr/doc/latest/class_gudhi_1_1alpha__complex_1_1_alpha__complex__3d.html

(but not the 2d version yet) My comment was about updating the gudhi wrapper(s) to reflect your changes, assuming your new version with non-rectangular domains remains compatible with CGAL's alpha shapes.

Do you have any specific requests on the periodic packages while I am working on them? (No promises I can do it, though :).)

Making sure the new versions are still compatible with Alpha_shape_[23] is the only thing that comes to mind. Unless you want to create a dD version of course :wink: .

mglisse avatar Aug 25 '20 08:08 mglisse