GT-New-Horizons-Modpack icon indicating copy to clipboard operation
GT-New-Horizons-Modpack copied to clipboard

Published 20 hours ago • verified publisher icon GTNewHorizons

Implementation: Adds raw ores as a valid quest imput.

Open Ethryan opened this issue 10 months ago • 3 comments

Requires: #2502

Ethryan avatar Apr 21 '24 17:04 Ethryan

Tier 2 - MV: Removed the Nether Tantalum quest and combined it as an option in the regular one.

Ethryan avatar Apr 22 '24 12:04 Ethryan

Think I have edited all ore quest now @Dream-Master , this is just waiting on the main now.

Ethryan avatar Apr 22 '24 13:04 Ethryan

@Ethryan sure after 2.6.0 update

Dream-Master avatar Apr 22 '24 16:04 Dream-Master

It looks like this PR removes these two MV quest files (under Quests/ directory):

  • TantalumNether-AAAAAAAAAAAAAAAAAAAJeg==.json
  • OverworldTantalu-AAAAAAAAAAAAAAAAAAAHKw==.json

and adds this one:

  • TantalumOre-AAAAAAAAAAAAAAAAAAAHKw==.json

However, this means that the quest ID AAAAAAAAAAAAAAAAAAAJeg== no longer exists, but it continues to be referenced by the MV quest line because the MV quest line was not updated in this PR. This is likely due to a conflict with the quest line format change PR:

  • https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/pull/15749

The MV quest line folder should probably be updated to remove the TantalumNether-AAAAAAAAAAAAAAAAAAAJeg==.json quest, and also handle the rename of the OverworldTantalu-AAAAAAAAAAAAAAAAAAAHKw==.json quest to TantalumOre-AAAAAAAAAAAAAAAAAAAHKw==.json (this last step isn't strictly necessary, but it's good to keep things consistent). I tried fixing this (which did require merging changes from master into this branch), so it should be working now.

Fixing this should resolve:

  • https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/16277

D-Cysteine avatar May 17 '24 19:05 D-Cysteine

Looks good

Ethryan avatar May 17 '24 20:05 Ethryan