GT-New-Horizons-Modpack icon indicating copy to clipboard operation
GT-New-Horizons-Modpack copied to clipboard

`mob.wither.spawn` sound effect does not play when mods try to play it

Open D-Cysteine opened this issue 10 months ago • 1 comments

Your GTNH Discord Username

D-Cysteine

Your Pack Version

2.5.1

Your Server

SP

Java Version

Java 20

Type of Server

Single Player

Your Expectation

Perform any action which should play the mob.wither.spawn sound effect (this one: https://minecraft.wiki/images/Wither_spawn.ogg), and the sound effect should play.

I tested and confirmed this with the Witchery Horn of the Hunt, as well as the Warp Theory fake wither warp event (this one has been fixed in dev).

The Reality

The sound effect does not play (except when actually spawning the wither).

Your Proposal

This one might be tricky to fix in a good way, so I'm mainly filing this issue just so we remember it, and so people will find this write-up if they notice this problem.

I think the cause of this issue is that Extra Utilities 2 will suppress any sound effect containing mob.wither.spawn from being played when there isn't actually a wither nearby. This was meant to prevent spawning withers annoying everyone on the server, but it also affects mods that happen to use that sound. Unfortunately, it might be tricky to fix: we either have to go modify every affected mod to use a custom copy of the sound that doesn't have mob.wither.spawn in the name, or maybe we can do a mixin to fix or work around the check in Extra Utilities 2.

Here's a search which tries to find affected mods:

  • https://github.com/search?q=org%3AGTNewHorizons+mob.wither.spawn&type=code

Here's the fix for Warp Theory, which uses a custom copy of the sound:

  • https://github.com/GTNewHorizons/WarpTheory/pull/37

Final Checklist

  • [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • [ ] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

D-Cysteine avatar Apr 12 '24 19:04 D-Cysteine

It might be worth turning disableWitherNoisesIfNotNearby off in ExU config rather than changing mods to use a custom sound.

Lyfts avatar Apr 17 '24 19:04 Lyfts