GT-New-Horizons-Modpack icon indicating copy to clipboard operation
GT-New-Horizons-Modpack copied to clipboard

RecipeMapBackend.checkCollision() may have a problem; it occupies 20% of the startup time

Open wohaopa opened this issue 1 year ago • 2 comments

Your GTNH Discord Username

No response

Your Pack Version

2.5.1

Your Proposal

Perhaps there could be a cache or a more efficient solution to improve the current approach. Personally, I feel it shouldn't be this inefficient. 38fc97299e7de8ecf9e08ace901ab0ec 747e4eeed09ac974b08e3f7b446d583b

Your Goal

Optimize the recipe loading system for GT, such as implementing a caching system, to improve the startup speed of GTNH.

Your Vision

I hope the startup speed of GTNH can be faster so that I can launch it anytime I want to play, just like the quick startup of the "All the Fabric" modpack.

Final Checklist

  • [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this feature please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
  • [X] I believe there is nothing similar in the pack already, or the existing solution isn't good enough.
  • [X] I understand this change request may not attract enough attention and thus not be implemented.
  • [X] I understand this change request may be rejected due to other community members thinking it's inappropriate.
  • [X] I believe this feature would make the pack better.

wohaopa avatar Jan 30 '24 09:01 wohaopa

https://github.com/GTNewHorizons/GT5-Unofficial/blob/356bd9473ed21913e8793a06c796b853928b27ef/src/main/java/gregtech/api/recipe/RecipeMapBackend.java#L314

wohaopa avatar Jan 30 '24 09:01 wohaopa

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions[bot] avatar Apr 29 '24 09:04 github-actions[bot]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions[bot] avatar Jul 31 '24 11:07 github-actions[bot]