GT-New-Horizons-Modpack icon indicating copy to clipboard operation
GT-New-Horizons-Modpack copied to clipboard

Nanosuit Wings cause memory leakage of 30-40 MB per second when visible

Open ussdefiant60 opened this issue 1 year ago • 3 comments

Your GTNH Discord Username

ussdefiant60

Your Pack Version

2.4.1

Your Server

SP

Java Version

Java 20

Type of Server

Single Player

Your Expectation

Being able to have my inventory open without causing memory usage of the JRE to balloon.

The Reality

While i have my inventory open with the avatar visible or am in 3rd person mode while having Nanosuit Wings equipped, my RAM usage spikes well above the limits sets in the launcher at a rate of approximately 30-40 megabytes per second while not showing any inclination of decreasing when the Wings aren't being rendered. This fairly rapidly leads to all RAM/virtual memory on my PC being consumed, resulting in my JRE freezing and me letting forth a stream of expletives.

Notably, removing the Wings from being worn does not result in any of the RAM being recovered.

I will note that this happens to me on both Adoptium 20.0.2+9 and 17.0.8.1+1

Your Proposal

It seems possible that this issue is related to #13007 , as the symptoms are similar and both items require doing Thaumcraft things to unlock. I don't know enough of how the items are put together on the backend to be certain on that point.

I'll probably end up doing some VisualVM shenanigans to try and provide more info in the next couple of days.

Final Checklist

  • [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • [ ] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

ussdefiant60 avatar Oct 09 '23 17:10 ussdefiant60

Have you been able to recreate this in a creative world with just the nanosuit wings equipped?

Caedis avatar Oct 09 '23 21:10 Caedis

i can confirm that yes, this does happen in a creative world with only the Wings. I can also confirm that the issue extends to all the chest armours that EMT provides ( the 4 Wings, along with the Infused Quantum Chestplate.) It does not occur with any of the goggles/boots in the mods.

ussdefiant60 avatar Oct 10 '23 15:10 ussdefiant60

With the help of some mod devs I managed to get some details.

Memory traffic becoming higher when inventory opens or third person mode enabled.
Here some memory traffic sampling screenshots:
image image image

And here is the expanded graph from profiler: Allocation-telemetry (change extension to html and open in browser, since GitHub doesn't allow to attach html files).

Seems like some strange allocations located at least here: now wonder why https://github.com/GTNewHorizons/Electro-Magic-Tools/blob/master/src/main/java/emt/item/armor/chestplate/ItemInfusedQuantumChestplate.java#L392

Discord mod-dev message id: https://discord.com/channels/181078474394566657/603348502637969419/1212537688461148160

SKProCH avatar Feb 29 '24 00:02 SKProCH