GT-New-Horizons-Modpack icon indicating copy to clipboard operation
GT-New-Horizons-Modpack copied to clipboard

NEI falsly adds oredict substitutes to TC infusion

Open chochem opened this issue 1 year ago • 6 comments

Your GTNH Discord Username

chochom#0271

Your Pack Version

2.3.0

Your Server

sp

Java Version

Java 19

Type of Server

Single Player

Your Expectation

NEI should show recipes correctly.

The Reality

It doesnt.

Specifically I am trying to make Boots of the Traveller:

image

It shows both the fish and the feather can be chosen from many different options (well 2 for the feather, many for the fish). However this is incorrect. I put in a mudfish (which appears in NEI) and it would not start. switching to a vanilla fish fixed it immediately.

Your Proposal

Fix NEI. I am sure this also affects many other recipes.

Final Checklist

  • [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • [x] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

chochem avatar Mar 18 '23 16:03 chochem

Confirmed on 2.3.0, often replaces specific wood with just oak when shift clicking recipes and shows all oredicted stuff when looking at recipe

Ydrec avatar Mar 18 '23 16:03 Ydrec

I just tried 2.2.0.0 to see if its a new bug. but it was broken there too. weird that nobody made a ticket.

chochem avatar Apr 14 '23 20:04 chochem

Weird thing is infusion does have oredict support in code, and this oredict substitution cannot be turned off whatsoever.

Maybe I should go recheck that piece of code and see if it did the oredict check correctly..

Glease avatar Apr 15 '23 03:04 Glease

well yeah the tc4 oredict is indeed very wonky (read: outdated). it will correctly oredict if both expected and input have only one ore name. otherwise you'd bet your luck over which oredict name got registered first which is semi random.

Glease avatar Apr 15 '23 04:04 Glease

even pure tear is affected: image

chochem avatar Jul 22 '23 22:07 chochem

this is the plan, once glee8e has some time or if somebody else takes over. https://discord.com/channels/181078474394566657/603348502637969419/1157982116349489153

chochem avatar Feb 29 '24 20:02 chochem