GT-New-Horizons-Modpack icon indicating copy to clipboard operation
GT-New-Horizons-Modpack copied to clipboard

Assembly Line + Data bank lag

Open Eranicus opened this issue 2 years ago • 1 comments

Your GTNH Discord Username

Eranicus#5476

Your Pack Version

2.2.3

Your Server

SP

Type of Server

Single Player

Your Expectation

.

The Reality

After updating to 2.2.3 from pre-18 assembly lines + data bank combination started to lag 7 time more

Assembler connected to data bank (48 data sticks) on Pre-18

2022-10-12_01 27 10

Assembler connected to the same data bank (48 data sticks) on 2.2.3

2022-10-12_01 56 54

Your Proposal

please fix

Final Checklist

  • [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • [ ] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

Eranicus avatar Oct 11 '22 23:10 Eranicus

Did more tests and rescaned all the recipes in data bank, but results are the same as on screens. In my opinion this is very big problem considering amount of assemblers at end game bases and small time frame beetween recipes check. But the main question is what happened and why they lag x7 times compared to older pack versions ...

Eranicus avatar Oct 13 '22 00:10 Eranicus

23k ns is not really anywhere near serious issue, though I have to think this is because we now check if recipes are valid rather than just trusting the stick.

Connor-Colenso avatar Oct 16 '22 04:10 Connor-Colenso

23k ns is not really anywhere near serious issue, though I have to think this is because we now check if recipes are valid rather than just trusting the stick.

I just pointed to the difference, maybe its not big... but its still x7 times per assembler with 20-30+ assemblers at endgame bases. Anyway if you guys from dev. team think its ok , just close the ticket.

Eranicus avatar Oct 16 '22 04:10 Eranicus

i'm more worried about the worst time being 0.5ms honestly

23k ns is not really anywhere near serious issue, though I have to think this is because we now check if recipes are valid rather than just trusting the stick.

what's the point of checking the recipe if sticks are auto-updated?

Sphyix avatar Oct 19 '22 15:10 Sphyix

@Sphyix can you replicate this on delta, so we can compare the tick time.

boubou19 avatar Oct 19 '22 15:10 boubou19

Crafting 1 LuV Motors every 2 ticks javaw_Pui8JT688f

Crafting UHV circuits, seems like first tick is really heavy, (worst time) and it's probably the recipe checking javaw_qKF2yvr75J

Sphyix avatar Oct 19 '22 17:10 Sphyix

that is indeed concerning. We need to profile this and understand what's going on.

boubou19 avatar Oct 19 '22 18:10 boubou19

On my screens I was looking at recipes check moment on idle assembler and lag number also depends on amount of sticks inserted into databank

Eranicus avatar Oct 19 '22 18:10 Eranicus

On my screens I was looking at recipes check moment on idle assembler and lag number also depends on amount of sticks inserted into databank

all my databanks have around 100 sticks each

Sphyix avatar Oct 19 '22 19:10 Sphyix

This could possibly be fixed in newest TT release (Also needs newest GT5U)

minecraft7771 avatar Oct 22 '22 11:10 minecraft7771

This could possibly be fixed in newest TT release (Also needs newest GT5U)

Thanks, looks like it is fixed (idle mode during recipe check) My max tick also decreased

2022-10-22_16 15 42

Eranicus avatar Oct 22 '22 13:10 Eranicus

This issue has been FixedInDev for quite a while and nobody commented in 7 days. Remove FixedInDev label or comment or this will be closed in 1 days

github-actions[bot] avatar Oct 29 '22 13:10 github-actions[bot]