Angelica icon indicating copy to clipboard operation
Angelica copied to clipboard

Display List Cache Handling seems to omit under certain conditions

Open KAMKEEL opened this issue 1 year ago • 1 comments

Your GTNH Discord Username

kamkeel

Mod Version

1.0.0-alpha22+

Bug Report

After this commit: https://github.com/GTNewHorizons/Angelica/pull/744/commits/11f69466488776e6a02209121a60b1c6a15285f3

The handling for nested glNewList and glEndList calls for rendering seems to break or not be cached properly.

For example in CustomNPC+ and ModelBox is rendered multiple times to form the 3D Hair Feature located on NPCs

https://github.com/KAMKEEL/CustomNPC-Plus/blob/master/src/main/java/noppes/npcs/client/model/util/ModelScaleRenderer.java#L68

How it should look: 2024-12-19_17 28 57

After Commit: image

This commit was put into place when I reported large amounts of Item Displays caused heavy lag within Angelica. This commit does RESOLVE the lag-based item rendering but seems to break in other areas. 2024-12-19_17 30 22

Java Version

Java 21

Graphics Card Vendor

NVidia

Shaders

No

MCPF or other features disabled by default

No: Go ahead and create an issue

Mod List or GTNH Pack Version

  • CustomNPC+: https://www.curseforge.com/minecraft/mc-mods/customnpc-plus/files/5772024

Spawn a bunch of NPCs with 3D hair and eventually some will break when loading into the world.

Final Checklist

  • [X] I have searched the issues and haven't found a similar issue.
  • [X] I have read the known incompatibilities and this is not related to one of those.
  • [X] I am running an officially released version. (Or, if I've compiled it myself I plan to fix the issue)

KAMKEEL avatar Dec 19 '24 22:12 KAMKEEL

2024-12-29_20 55 38

Other instances where it breaks.

2024-12-29_20 56 17

KAMKEEL avatar Dec 30 '24 01:12 KAMKEEL