EndlessIDs icon indicating copy to clipboard operation
EndlessIDs copied to clipboard

[Bug]: mod file can't be rename, or else crash

Open XLin0mu opened this issue 2 years ago • 4 comments

OS

Windows

GPU

NVIDIA

Modpack (Optional)

many, such as ExtraUtil or Thaumcraft and so on

Game log

ExtraUtil's: ExUtillatest.log

and Thaumcraft's: TClatest.log

Description

When I change mod file's name, even just a ASCLL letter, it get crashed when chunks generating. Actually it's not only happend on some particular mods, but for reference, log's above. btw there's one detail, tc's crash is after world created a little time, but exutil's was at world creating progress.

XLin0mu avatar Aug 16 '23 21:08 XLin0mu

EndlessIDs uses the filenames to detect what mods are present for mixins, which are used to inject code into other mods to make them compatible with EndlessIDs. This cannot be done through the regular forge APIs, because forge is not yet loaded fully at that point.

Solution: Do not rename mod files

FalsePattern avatar Aug 16 '23 22:08 FalsePattern

fine.

XLin0mu avatar Aug 16 '23 22:08 XLin0mu

Wait, how about puting it into config file as an optional item? So modpack makers can rename mod's filename as they wish. Sorry for the request but it's really kind of meaningful to some non-English country's users.

XLin0mu avatar Aug 16 '23 22:08 XLin0mu

I figured out a solution that doesn't require filenames. It's a bit complicated but i think i can upload the fix later this week.

FalsePattern avatar Aug 17 '23 04:08 FalsePattern