vital-ui-kit-react icon indicating copy to clipboard operation
vital-ui-kit-react copied to clipboard

各個 UI 元件應該有選擇性的 id

Open caasi opened this issue 4 years ago • 3 comments

Describe the solution you'd like 現在 UI 元件有 className 如果能有選擇性的 id 會更好。

Additional context 原生的 React UI 元件通常會有 id, classNamechildren

caasi avatar May 18 '20 05:05 caasi

應該已經可以把id props pass 下去了 what else do we need?

0xycvv avatar May 26 '20 09:05 0xycvv

還有 style ,看來可以參考看看: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L1743

caasi avatar May 26 '20 09:05 caasi

如果是 extends from BoxProps or straight from sc I think it should be fine 有些舊的component: Menu.. 要改一下props types

0xycvv avatar May 26 '20 15:05 0xycvv