vital-ui-kit-react icon indicating copy to clipboard operation
vital-ui-kit-react copied to clipboard

Improve menu and list customize options

Open 0xycvv opened this issue 6 years ago • 6 comments

  • [x] menu height
  • [ ] list link

0xycvv avatar Jun 14 '18 04:06 0xycvv

Could you give us more details so I can takeover this issue maybe in May?

caasi avatar Mar 21 '20 03:03 caasi

As I remember, List and ListItem do not support for link component ( react router or any other routing lib) I will add more details on monday

0xycvv avatar Mar 21 '20 09:03 0xycvv

Cool. Thank you. I am not in a rush.

caasi avatar Mar 22 '20 04:03 caasi

this is what my thought of adding support for router link component.

+ import { Link } from 'react-router';

      <List>
-       <List.Item hasLink>
+       <List.Item component={Link} hasLink>
	  </List>

0xycvv avatar Mar 23 '20 05:03 0xycvv

I see. It looks like the as prop in Semantic UI React.

caasi avatar Mar 23 '20 09:03 caasi

A proper type for as:

import React, { FC, ElementType } from 'react';

interface Props {
  as?: ElementType;
}

const Comp: FC<Props> = ({ as: Comp = 'div' }) => {
  return <Comp>hello</Comp>;
};

caasi avatar May 19 '20 02:05 caasi