gnome-shell-extension-gsconnect icon indicating copy to clipboard operation
gnome-shell-extension-gsconnect copied to clipboard

Notifications > "Share When Active" always initializes enabled

Open ferdnyc opened this issue 1 year ago • 3 comments

Describe the bug

So, this is the dumbest little display bug, a silly little thing that is the epitome of a "good first issue" if anyone is looking to dive in and make a fix.

Whenever a device's Notifications preferences view is first opened, the "Share When Active" switch always initializes as sensitive even if "Share Notifications" is disabled (which is supposed to make "Share When Active" insensitive, the same way it does all the applications in the list):

First arrival at "Notifications" after opening "Mobile Settings"

image

It's purely a setup bug — if you cycle "Share Notifications" on and then back off again, it'll become insensitive, and it'll stay that way as long as the Settings window is still open. (The bug reoccurs each time the window is newly constructed, though.)

After cycling "Share Notifications"

image

Steps to reproduce

  1. Open "Mobile Settings"
  2. Click a device (connected or not)
  3. Switch to "Notifications"
  4. If "Share Notifications" is on, turn it off, close the window, and start back from step 1 again.

Expected behavior

"Share When Active" never appears sensitive (able to be interacted with) unless "Share Notifications" is switched on.

GSConnect version

54 & 55

Installed from

GNOME Extensions website

GNOME Shell version

43.3 & 44

Linux distribution/release

Fedora 37 – 38b

Paired device(s)

No response

KDE Connect app version

No response

Plugin(s)

No response

Support log

No response

Screenshots

No response

Notes

No response

ferdnyc avatar Apr 08 '23 21:04 ferdnyc

i would like to work on this issue can you please assign it to me ?

sumitshinde-84 avatar Apr 09 '23 06:04 sumitshinde-84

I would like to work on this issue , can you please assign me .

aditya-mistri avatar Jun 04 '23 18:06 aditya-mistri

I don't know what this assignment business is about. Feel free to send a pull request

daniellandau avatar Jun 05 '23 08:06 daniellandau