gnome-shell-extension-gsconnect icon indicating copy to clipboard operation
gnome-shell-extension-gsconnect copied to clipboard

[TRANSLATIONS] Translators please subscribe to be notified of changes

Open andyholmes opened this issue 6 years ago • 92 comments

This is a thread for discussion of translations and notification of changes to translatable string. If you are a translator, please subscribe to this issue to be notified of changes.

andyholmes avatar Oct 11 '17 04:10 andyholmes

I've made a translation for polish language, but before I contribute I wanted to test this in practice. How can I make gsconnect to use my translation? Simply pasting *.po file didn't work. Commands from wiki

ninja gsconnect-pot
ninja gsconnect-update-po

did not seems to work.

Arquanite avatar Dec 21 '17 13:12 Arquanite

Sorry about that, I've changed the text domain to org.gnome.Shell.Extensions.GSConnect in git, but I usually wait until a release to update the wiki. You can use these commands:

ninja org.gnome.Shell.Extensions.GSConnect-pot
ninja org.gnome.Shell.Extensions.GSConnect-update-po

You also need to add your language to the LINGUAS file before running those commands, I'll add that to the wiki too. This is just the language code on a line by itself, eg "pl".

The change in text domain shouldn't change anything on your side, and I won't be changing it again. I also plan on putting some simple instructions for translating the WebExtension but let me know if your interested now.

andyholmes avatar Dec 21 '17 13:12 andyholmes

Ok, if better instructions will be available I will make a pull request. For now I have translated po file, some other files were generated by this commands but extension still is in english.

Arquanite avatar Dec 21 '17 13:12 Arquanite

Okay, I've updated the Wiki to be a little clearer about all the steps.

https://github.com/andyholmes/gnome-shell-extension-gsconnect/wiki/Translating

Let me know if you need more help getting the translation working.

andyholmes avatar Dec 21 '17 14:12 andyholmes

I'm about ready to release v8, let me know if you'd like me to wait to get your translation included.

andyholmes avatar Dec 26 '17 19:12 andyholmes

I've just created pull request. I'm sorry that it took so long, I had some issues with my laptop (gnome was half polish half english :o)

Arquanite avatar Dec 26 '17 20:12 Arquanite

No problem, I think that was GSConnect causing that :/

andyholmes avatar Dec 27 '17 03:12 andyholmes

Are we supposed to fork master or v10? If it's master, po/* files are missing the gsettings.js and preferences.js merge (and the first ninja commands fail).

shibotto avatar Feb 06 '18 19:02 shibotto

@shiba89 Sorry about that. I've sort of broken a lot of things on the way to v10 and a few commits were pushed before I made a new branch. Currently the next version is not ready to be translated and won't be until I sort some things out.

Sorry about the delayed reply.

andyholmes avatar Feb 12 '18 00:02 andyholmes

Ok, let me know when things are ready. I'd be happy to provide you with a French translation.

mkey-cdx avatar Feb 12 '18 22:02 mkey-cdx

Hello translators. I have be in conversation with the reviewers of the Gnome Extensions website and I'm planning a v9 bugfix release that will be distributed fairly soon (under a week).

There will still be many translation changes in v10, however the version to be released on the official website will be around for a fair amount of time, so if you would like to submit a new/updated translation please let me know so I can hold off before releasing.

andyholmes avatar Mar 03 '18 10:03 andyholmes

Hello @andyholmes. As I said, I'll be able and happy to give you a French translation. This should be done within a week.

mkey-cdx avatar Mar 03 '18 12:03 mkey-cdx

Hi! I've just updated the italian translation. ;)

amivaleo avatar Mar 03 '18 14:03 amivaleo

@mkey-cdx sounds good, i'll let the extension reviewer know when they get back to me.

@amivaleo thanks again!

andyholmes avatar Mar 03 '18 14:03 andyholmes

Hello translators!

I know it's been a long time coming, but GSConnect is now ready to accept translations for v13. You will have to pull from master, since the last development release (v13-RC1) does not include the most recent POT file. The usual instructions are available on the Translating page.

New in v13 is translatable strings from the WebExtension in the same file. Just submit your translation for the Gnome Shell extension and the next time I build the WebExtension your language will automatically be included -- no extra work!

Ubuntu 18.10 is due to be released on October 18 and that will also be the target release date for v13. However, the review process for Gnome Shell extensions is volunteer based and can be quite long, so please ask if you need more time and I will be happy to delay release.

andyholmes avatar Oct 11 '18 17:10 andyholmes

intltool-update -m is reporting these two files missing from POTFILES:

data/debug.ui
src/service/plugins/contacts.js

The first one looks like a false positive, but the second indeed looks missing.

piotrdrag avatar Oct 11 '18 19:10 piotrdrag

Ah thanks, fixed. Yep, debug.ui I think shouldn't be translated since users (usually) shouldn't use that.

andyholmes avatar Oct 11 '18 19:10 andyholmes

Some strings are missing, like: Mute Microphone and Display Mode. Also, I tested the translation I made, and some things still appear in English.

ricvelozo avatar Oct 16 '18 03:10 ricvelozo

Sorry, everyone! Seems like a lot of strings in the Glade files were not marked as translatable.

I've updated the translation file, so you should be able to pull from master and adjust your translation.

andyholmes avatar Oct 16 '18 03:10 andyholmes

Still some strings are missing / not getting translated:

  • The extension description in about dialog
  • To device / from device (clipboard sync)
  • Items from Menu (Connect LAN, Unpair, Connect to..., etc)

ricvelozo avatar Oct 16 '18 05:10 ricvelozo

Okay, hopefully I have fixed the menus being translated now. The About dialog I'll have to fix for next release. Right now it's automatically taken from metadata.json which doesn't get translated.

Edit Nope, haven't fixed it. I'm investigating why only menus aren't being translated. Edit2 Got it!

andyholmes avatar Oct 16 '18 14:10 andyholmes

Do Not Disturb toggle in menu and DnD duration popup are also untranslateble

L0sted avatar Oct 16 '18 21:10 L0sted

Should be fixed now, but you have to re-pull and restart gnome shell.

andyholmes avatar Oct 16 '18 21:10 andyholmes

Nice! All right here.

ricvelozo avatar Oct 17 '18 21:10 ricvelozo

Hi everyone, I think we're about ready to release v15 which has a few new and changed strings (v14 was a very minor release that isn't reviewed on e.g.o yet). @amivaleo your translation should already be up to date, so nothing to do for you.

The changes are pretty minor so release date will be Monday, November 5th, unless someone needs more time.

andyholmes avatar Nov 04 '18 05:11 andyholmes

Sorry guys, we made a little mistake with one or two "pluralized" strings that may require an update on your part. As usual, feel free to ask for more time if you need us to hold back release.

andyholmes avatar Nov 04 '18 23:11 andyholmes

@andyholmes Some strings turned comments after update from POT... Can you check if is ok? PR https://github.com/andyholmes/gnome-shell-extension-gsconnect/pull/302

ricvelozo avatar Nov 05 '18 07:11 ricvelozo

I answered @ricvelozo 's question over at #302, but for the group:

The commented strings are ones that we removed from the source, or changed their (English) meaning since the last time the master .pot file was generated. They're stored in comments that way to make it clear that was intentional. (And also so any translations provided for those strings will be preserved, in case they're put back into the code at a later date.)

ferdnyc avatar Nov 05 '18 15:11 ferdnyc

I always use Poedit, so I never see any commented strings anyway lol

Vistaus avatar Nov 05 '18 16:11 Vistaus

@ferdnyc yes, I just wanted to confirm because the last time the removal wasn't intentional. 😃

ricvelozo avatar Nov 05 '18 20:11 ricvelozo