digitalgov.gov icon indicating copy to clipboard operation
digitalgov.gov copied to clipboard

Published 20 hours ago • verified publisher icon GSA

Refactor templates markup

Open nick-mon1 opened this issue 11 months ago • 1 comments

Summary

Removes un-necessary grid tags, classes and duplicate grid styles to simplify template markup.

Preview

Link to Preview

Solution

  • [x] Removed duplicate grid-container classes and replaced with one top parent
  • [x] Removed un-necessary grid-row classes when not needed (events/single.html)
  • [x] Removed un-necessary div tags
  • [x] Improved header spacing on events landing pages

Layout Enhancements

events/list.html

Removed equal spacing for header Screen Shot 2024-03-11 at 4 53 59 PM

authors/list.html

Increased spacing below button Screenshot 2024-03-14 at 4 55 53 PM
Increased spacing above name Screenshot 2024-03-14 at 4 57 48 PM

authors/terms.html

Increased spacing above title Screenshot 2024-03-14 at 4 58 56 PM

How To Test

  1. First Step
  2. Second Step
  3. Third Step

Dev Checklist

  • [ ] PR has correct labels
  • [ ] A11y testing (voice over testing, meets WCAG, run axe tools)
  • [ ] Code is formatted properly

nick-mon1 avatar Mar 11 '24 15:03 nick-mon1

:mag: Preview in Federalist

github-actions[bot] avatar Mar 11 '24 15:03 github-actions[bot]

Hello! 👋 It looks like this pull request is stale because it has been open 60 days with no activity. This is usually because the request was already solved or it is no longer applicable. If this pull request should remain open, remove the stale label or add a comment. Otherwise, this will be closed in 7 days.

github-actions[bot] avatar Aug 05 '24 07:08 github-actions[bot]