data.gov icon indicating copy to clipboard operation
data.gov copied to clipboard

Fix integration tests in harvesting logic repo

Open rshewitt opened this issue 10 months ago • 3 comments

all integration tests for harvesting logic repo on main should pass out-of-the-box

How to reproduce

  1. pull down main
  2. run integration tests via poetry run pytest --ignore=./tests/unit --ignore=./tests/database

Expected behavior

all integration tests pass

Actual behavior

some integration tests fail

Sketch

  • update documentation to enable successful run of tests ( if needed )
  • resolve test issues

rshewitt avatar Apr 22 '24 19:04 rshewitt

on the topic of integration tests, we may want to have another discussion on what we consider an integration test ( i.e. a test of multiple parts of an application acting together vs. a unit test that actually interacts with a service ). the repo should make sense to the team and not be confusing.

rshewitt avatar Apr 22 '24 19:04 rshewitt

two of the tests ( retrieving a task and cancelling a task ) are failing

rshewitt avatar Apr 22 '24 19:04 rshewitt

it seems that getting a task by name isn't reliable. Using the guid cf assigns the task works.

rshewitt avatar Apr 22 '24 21:04 rshewitt