Unknown Contact Email for non-data.json datasets

[FuhuXia]

On catalog, datasets always show "Unknown" as value for the field Contact Email. It only happens to datasets harvested from non-data.json harvest type.

How to reproduce

Example dataset 1 Example dataset 2

Expected behavior

Display correct email address if there is a valid value.

Actual behavior

It displays Unknown as value. But the Unknown is actually hyper-linked to a valid email address.

Sketch

[jbrown-xentity]

@hkdctol this is the issue, it's already created. We have another dataset use case of this: https://catalog.data.gov/dataset/large-scale-international-boundaries3 I believe there is something fishy with this logic, and we may be able to fix this to the desired outcome: https://github.com/GSA/ckanext-datagovtheme/blob/main/ckanext/datagovtheme/templates/templates_new/package/read.html#L353-L359

[btylerburton]

updated link to the above: https://github.com/GSA/ckanext-datagovtheme/blob/main/ckanext/datagovtheme/templates/package/read.html#L353-L359

[nickumia-reisys]

I don't remember the exact reason for why the fix worked, but it had to do the template not handling the unknown case properly. Either way, the example datasets above have been fixed and this is actually completed.