deepparse icon indicating copy to clipboard operation
deepparse copied to clipboard

Setup-nginx

Open GameSetAndMatch opened this issue 1 year ago • 6 comments

Descrition:

  • Added nginx code to run model inference on endpoint
  • Updated api test suite

GameSetAndMatch avatar Oct 04 '23 21:10 GameSetAndMatch

It misses the URL format to see the doc of the API and the Deepparse doc somewhere in the documentation (the README and the .rst files).

davebulaval avatar Oct 06 '23 18:10 davebulaval

I think using a reverse proxy is a little overkill for the use case, but it's fine. It would just be a good idea to mention it in the docs as well as other details like the fact that there's a mounted volume.

Good job overall!

MAYAS3 avatar Oct 06 '23 18:10 MAYAS3

This PR is stale because it has been open 60 days with no activity.
Stale pull requests will automatically be closed 30 days after being marked Stale
.

github-actions[bot] avatar Dec 17 '23 00:12 github-actions[bot]

@GameSetAndMatch ETA to finish this?

davebulaval avatar Dec 30 '23 21:12 davebulaval

I think most of the work consist in reviewing, the PR could be finalized by Jan 5th. @davebulaval

GameSetAndMatch avatar Dec 30 '23 21:12 GameSetAndMatch

This PR is stale because it has been open 60 days with no activity.
Stale pull requests will automatically be closed 30 days after being marked Stale
.

github-actions[bot] avatar Mar 17 '24 00:03 github-actions[bot]