GPlates
plate model must have topology features...
If using model = gplately.PlateReconstruction(rotation_model, topology_features=None, static_polygons=static_polygons)
then
gplot = gplately.PlotTopologies(model) results in the error
ValueError: Plate model must have topology features.
But not all plate models have topologies.
It seems like if you change the same line above to
model = gplately.PlateReconstruction(rotation_model, topology_features=[], static_polygons=static_polygons)
then it all works (strange, since None is the default behaviour)
Is there a way in the backend to have None = [] for the topology_features, since you can't actually use your plate model for plotting? Or does this create issues elsewhere?
thank @nickywright bring this issue up.
If the topology_features is None or [], all the topological plotting will fail and raise exceptions, such as plot_ridges_and_transforms(), plot_trenches(), etc.
@brmather @lauren-ilano @laurilano We need to decide which behaviour is preferable?
- raise the error at the construction of PlotTopologies object (current behaviour)
- check topology_features for all topological plotting functions, print warnings and do nothing(not raise exception) if the topology_features is None or []
I am inclined to prefer option 2. But I am flexible regarding this matter.
