GPflowOpt icon indicating copy to clipboard operation
GPflowOpt copied to clipboard

MGP

Open javdrher opened this issue 7 years ago • 4 comments

In-house version of #60 . Full credits to @nknudde for implementing this.

I already took care of merging #64 and derived the MGP from it. Also introduced a tf_wraps file for the rowwise_gradients. To be merged after releasing.

javdrher avatar Aug 10 '17 01:08 javdrher

Codecov Report

Merging #65 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #65      +/-   ##
=========================================
+ Coverage   99.78%   99.8%   +0.01%     
=========================================
  Files          16      18       +2     
  Lines         928    1004      +76     
=========================================
+ Hits          926    1002      +76     
  Misses          2       2
Impacted Files Coverage Δ
GPflowOpt/acquisition/ei.py 100% <ø> (ø) :arrow_up:
GPflowOpt/__init__.py 100% <100%> (ø) :arrow_up:
GPflowOpt/acquisition/acquisition.py 100% <100%> (ø) :arrow_up:
GPflowOpt/models.py 100% <100%> (ø)
GPflowOpt/scaling.py 100% <100%> (ø) :arrow_up:
GPflowOpt/tf_wraps.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a473070...c2764eb. Read the comment docs.

codecov-io avatar Aug 10 '17 01:08 codecov-io

I skipped the ModelWrapper class in my review as it is a separate PR #64

icouckuy avatar Aug 14 '17 20:08 icouckuy

I'd like to comment that this isnt to be merged until GPflow/GPflow#480 is addressed, or we hack some way around it.

javdrher avatar Aug 14 '17 20:08 javdrher

@nknudde what's the state on this? Is it more compatible with GPflow 1.0?

Or is using MCMC to marginalize hyperparameters fast and accurate enough?

icouckuy avatar Nov 11 '17 19:11 icouckuy