VulkanMemoryAllocator

VulkanMemoryAllocator copied to clipboard

Agrael1

Trivial compilation test is required because the sample is windows-specific. Linux CI is needed because pull requests must stop breaking linux builds. The tiny `m_Handle(VMA_NULL)` -> `m_Handle()` fix is needed...

Mrkol

During defragmentation, users can specify that a move should be ignored, and the block the candidate allocation resides in will be marked as "immovable" for the remainder of the pass....

CannibalVox

Stack corruption calling vmaGetHeapBudgets without VK_EXT_memory_budget

1

The readme indicates that this should work regardless: > VK_EXT_memory_budget: Used internally if available to query for current usage and budget. If not available, it falls back to an estimation...

rnbhatt

Clarify docs and improve pool API thread-safety guarantees if possible

2

I suspect working with pool for specific pool can be thread-safe (even with `VMA_ALLOCATOR_CREATE_EXTERNALLY_SYNCHRONIZED_BIT` set but without actual synchronization) relative to working with other pools and general API. E.g. I...

tomilov

Write a new test which covers 'advanced data uploading' from docs

5

In my opinion, it would be better to have a test which covers the topic of advanced data uploading in detail. The current sample code from the docs still has...

IAmNotHanni

VmaBlockBufferImageGranularity::RoundupAllocRequest will cause an allocation to stretch to occupy the entirety of the buffer image granularity "slots" it is located in, if bufferimagegranularity is relatively small (less than 256 bytes)....

CannibalVox

Not compiling when VMA_EXTERNAL_MEMORY_WIN32 disabled.

1

https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/blob/de8e65796ae5bf780a828c47376e6744bf1f4336/include/vk_mem_alloc.h#L10597 Hey,. this line is not compiling, when define switch is not specified. In one scenario `VmaWin32Handle` is a class with explicite handle construcor, but in other it has no...

sagaceilo

Hi, I have recently been working on Cef library, and since I use VMA I would like to have a way to import external memory. Right now it works by...

Agrael1

vmaDestroyImage memory leak

2

```diff VMA_CALL_PRE void VMA_CALL_POST vmaDestroyImage( VmaAllocator VMA_NOT_NULL allocator, VkImage VMA_NULLABLE_NON_DISPATCHABLE image, VmaAllocation VMA_NULLABLE allocation) { VMA_ASSERT(allocator); + if(image == VK_NULL_HANDLE && allocation == VK_NULL_HANDLE) + { + return; + }...

IoIxD