RadeonProRenderUSD
RadeonProRenderUSD copied to clipboard
GPUOpen-LibrariesAndSDKs
Update Houdini integration for version 20 and elaborate README
PURPOSE
This PR fixes compile issues that occur during build with version 20 of the Houdini engine. Additionally, a small note about Python version with HFS environment variable was put to make it easier for people to adjust to the build environment.
EFFECT OF CHANGE
Makes it possible to use the plugin with version 20.
TECHNICAL STEPS
In domeLight.cpp, a compile-time check occurs with HDK_API_VERSION >= 20000000 to choose the correct type. This pattern is also visible in VOP_RPRMaterial.(h|cpp), where HDK_API_VERSION helps to distinguish. But in case the plugin source does not care about version compatibility, I think this code can be made more concise by not checking for version.
NOTES FOR REVIEWERS
The build was confirmed working with an Indie installation of Houdini version 20.
Please let me know if there's a documented minimum supported Houdini or if it is commit based (for example, latest commit works on 19, merge will be only 20+ etc.), and I can simplify accordingly if that's a viable path.
Thank you!
Could you check if it can be built and work also on Ubuntu 22.04? I have tried it on my side, but it didn't work.
@ShinFujieda Sure thing, I'll take a look at it this week. Thank you for the information!
@ShinFujieda I've sent a commit to fix the build issues in Ubuntu 22.04! The issue was mostly due to the C++ Standard version not propagating well to the compiler and the new SDK requiring C++17 at the very least.
Could you please try again with the latest commit of this branch to see if the update resolves the issue? If not, I will be prompt to help.
Sorry that it took a while to reproduce due to certain licensing limitations in the container environment, but I managed to find a way. From here on, I can coordinate and help better.
Thank you very much!
@mehmetoguzderin Thanks for the update! But when I tried on my side with Houdini 20.0.653, it seems the build succeeded and I could see RPR as a renderer just after running Houdini.
However, once running RPR on the viewport, it disappears. Have you seen this kind of issue?
If not, could you tell me how to build on your side?
@ShinFujieda I will check again and update about the situation. Thank you!
@ShinFujieda I was able to reproduce this issue and confirm that it is not happening on Windows but only on Ubuntu. Is there a similar problem with Ubuntu execution in version 19? Or is this a newly emerged problem? Since I don't have previous version's environment ready, this would be helpful to debug. Thank you!
@mehmetoguzderin Hmm it seems it crashes with a segmentation fault when rendering a scene with RPR on Houdini 19.5.805.
Though the issues are not totally the same, we can see the problem with both plugins for H19 and H20 built on Ubuntu 22.04. Then, it might be better to resolve this issue as another PR if you can manage it. Thanks.
@ShinFujieda Thank you very much for the confirmation! Then maybe this PR can be merged to enable Houdini 20 on Windows while I take a look at resolving Ubuntu issues in existing versions in its own investigation. Appreciated